ahham - Technical Training Estate module by ahmedhamila · Pull Request #1171 · odoo/tutorials

ahmedhamila · 2026-02-16T10:20:21Z

No description provided.

robodoo · 2026-02-16T10:20:24Z

ltinel

Good job, almost nothing to say 🙂

estate/__manifest__.py

ltinel · 2026-02-16T14:58:19Z

@ahmedhamila Regarding your commits:

Could you create one commit per chapter (no need for a FIX commit, you can just squash the fix with the "main" commit).
FIX commits are for bug fixes, not linting and formatting (See [1]). You can use CLN or LINT for those (but squashing the commits is better in this case).
Could you use imperative style for the first line of your commit message? I.e. "add" instead of "added".
The module name (following [ADD]) can be lower case.

[1] https://www.odoo.com/documentation/master/contributing/development/git_guidelines.html

[LINT] estate: add linting and formatting [IMP] estate: add estate_property model

…tionship with estate_property

ltinel

Great work 😄

ltinel · 2026-02-17T09:47:58Z

estate/views/estate_property_views.xml

+                <field name="bedrooms"/>
+                <field name="living_area"/>
+                <field name="facades"/>
+                <filter name="Available Properties" domain="['|',('state','=','new'),('state','=','offer_received')]"/>


This can be a bit simpler:

Suggested change

<filter name="Available Properties" domain="['|',('state','=','new'),('state','=','offer_received')]"/>

<filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"/>

ltinel · 2026-02-17T09:54:12Z

estate/models/estate_property.py


-    name = fields.Char(string="Name", required=True)
+    name = fields.Char(string="Title", required=True)
    description = fields.Text(string="Description")


Just FYI (no need to change anything): if you don't specify a string parameter to a field, it will use the field name as string (and I believe it correctly converts underscores to spaces and capitalizes the first letter of each word). So if the string parameter and the field name are the same, you don't strictly need to specify it.

Suggested change

description = fields.Text(string="Description")

description = fields.Text()

ltinel · 2026-02-17T10:05:00Z

estate/models/estate_property.py

+    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
+    buyer_id = fields.Many2one("res.partner", string="Buyer")
+    salesman_id = fields.Many2one("res.users", string="Salesman", default=lambda self: self.env.user)
+    property_tag_ids = fields.Many2many("estate.property.tag")


Suggested change

property_tag_ids = fields.Many2many("estate.property.tag")

property_tag_ids = fields.Many2many("estate.property.tag", string="Tags")

ltinel · 2026-02-17T12:03:23Z

estate/views/estate_property_views.xml

                            <field name="name"/>
                        </h1>
                    </div>
+                    <field name="property_tag_ids" widget="many2many_tags"/>


Could you move this into the oe_title div?

ltinel · 2026-02-17T12:17:46Z

estate/models/estate_property.py

+
+    @api.depends("living_area", "garden_area")
+    def _compute_total_area(self):
+        for record in self:


It's slightly nicer to use a more descriptive name :) (same below)

Suggested change

for record in self:

for property in self:

ltinel · 2026-02-17T12:18:38Z

estate/models/estate_property_offer.py

+
+    @api.depends("validity")
+    def _compute_date_deadline(self):
+        for record in self:


Same here (and below)

Suggested change

for record in self:

for offer in self:

ltinel · 2026-02-17T12:22:55Z

estate/models/estate_property_offer.py

+    @api.depends("validity")
+    def _compute_date_deadline(self):
+        for record in self:
+            if record.create_date:


This will prevent the deadline from being set when the record is being created. Could you use a fallback (e.g. today) if create_date isn't set yet? Same for the inverse method.

ltinel · 2026-02-17T12:24:06Z

estate/models/estate_property_offer.py

+    validity = fields.Integer(string="Validity (days)", default=7)
+    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+
+    @api.depends("validity")


This also depends on create_date :)

ltinel · 2026-02-17T13:00:31Z

FYI, if you scroll to the bottom of your PR, you'll find some Runbot links (i.e. the ci/style and ci/tutorial checks), which are failing. If you click on the links, you'll find some suggestions. Could you implement those to make the checks pass?

ltinel

Thanks, great work again :)

ltinel · 2026-02-17T14:01:08Z

estate/models/estate_property.py

+            else:
+                record.state = "cancelled"


No need for the else condition since there's a raise statement in the if (which shortcuts the method anyway):

Suggested change

else:

record.state = "cancelled"

record.state = "cancelled"

ltinel · 2026-02-17T14:01:40Z

estate/models/estate_property.py

+            else:
+                record.state = "sold"


Same here:

Suggested change

else:

record.state = "sold"

record.state = "sold"

ltinel · 2026-02-17T14:08:00Z

estate/models/estate_property_offer.py

+            for offer in record.property_id.offer_ids:
+                if offer != record:
+                    offer.status = "refused"


Instead of this, you could refuse all offers (including the accepted one), before accepting the offer in question (as you do above):

record.property_id.offer_ids.status = "refused"

But this line should be moved before the record.status = "accepted" statement.

This works because the ORM has special handling for recordsets: this line will set the status of all offers in the recordset to refused.

ltinel · 2026-02-17T14:22:12Z

estate/models/estate_property_offer.py

            if record.create_date and record.date_deadline:
                record.validity = (record.date_deadline - record.create_date.date()).days
+
+    def action_accept_offer(self):


I guess you should also mark the property as having an accepted offer?

record.property_id.state = "offer_accepted"

ltinel · 2026-02-17T14:25:19Z

estate/models/estate_property_offer.py

+        return True
+    def action_refuse_offer(self):
+        for record in self:
+            record.status = "refused"


Maybe we should also update the related property, in case the offer was accepted and then refused? (it's a bit of an edge case though 😅 )

ltinel · 2026-02-17T15:58:57Z

estate/models/estate_property.py

+    @api.constrains("selling_price")
+    def _check_selling_price_minimum_ratio(self):
+        for property in self:
+            if not property.selling_price:
+                continue
+            if float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:
+                raise ValidationError("The selling price must be at least 90% of the expected price.")


Could you move these before the action methods? See also https://www.odoo.com/documentation/master/contributing/development/coding_guidelines.html#symbols-and-conventions

ltinel · 2026-02-17T16:02:19Z

estate/models/estate_property.py

+    @api.constrains("selling_price")
+    def _check_selling_price_minimum_ratio(self):
+        for property in self:
+            if not property.selling_price:


This is a bit risky, it would be safer to use float_is_zero (which allows for precision errors).

…perties page in form view

ahmedhamila changed the title ~~Technical Training Estate module~~ ahham - Technical Training Estate module Feb 16, 2026

ltinel reviewed Feb 16, 2026

View reviewed changes

estate/__manifest__.py Outdated Show resolved Hide resolved

estate/__manifest__.py Outdated Show resolved Hide resolved

ahham added 5 commits February 16, 2026 16:31

[ADD] estate: add estate property module declaration

2be8a14

[IMP] estate: add estate_property model

4d165da

[LINT] estate: add linting and formatting [IMP] estate: add estate_property model

[IMP] estate: add access control to estate_property model

426e4bc

[IMP] estate: add menus and action for estate_property

f0f5d26

[IMP] estate: add list,form and search custom views for estate_property

f37f977

ahmedhamila force-pushed the 19.0-training-ahham branch from 4b9c7ca to f37f977 Compare February 16, 2026 15:34

ahham added 3 commits February 17, 2026 10:28

[IMP] estate: add property type,tag and offers and defined their rela…

332eef4

…tionship with estate_property

[IMP] estate: add computed fields and set onchange method

02cf3dc

[IMP] estate: add actions for property offers and property state

3245306

ltinel reviewed Feb 17, 2026

View reviewed changes

[IMP] estate: add sql and python constraints to estate models

60becd9

ahmedhamila force-pushed the 19.0-training-ahham branch from 70036cc to 60becd9 Compare February 17, 2026 13:18

ltinel reviewed Feb 17, 2026

View reviewed changes

[IMP] estate: add inline editing, widgets and stat_button

ef6a1a9

ahmedhamila force-pushed the 19.0-training-ahham branch from a9e522a to ef6a1a9 Compare February 18, 2026 08:15

[IMP] estate: override CRUD methods and extend user model to have pro…

6f34f69

…perties page in form view

ahmedhamila force-pushed the 19.0-training-ahham branch from 8c86fa6 to a41e581 Compare February 18, 2026 10:32

[ADD] estate_account: override sold action to create invoice for buyer

5510c98

ahmedhamila force-pushed the 19.0-training-ahham branch from a41e581 to 5510c98 Compare February 18, 2026 11:42

	<filter name="Available Properties" domain="['\|',('state','=','new'),('state','=','offer_received')]"/>
	<filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"/>

	description = fields.Text(string="Description")
	description = fields.Text()

	property_tag_ids = fields.Many2many("estate.property.tag")
	property_tag_ids = fields.Many2many("estate.property.tag", string="Tags")

Conversation

ahmedhamila commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

ltinel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ltinel commented Feb 16, 2026

Uh oh!

ltinel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ltinel commented Feb 17, 2026

Uh oh!

ltinel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants